Skip to content

feat: emit enriched agent-core trace events#28

Merged
Svaag merged 1 commit into
mainfrom
feature/agent-core-trace-v05
Jun 29, 2026
Merged

feat: emit enriched agent-core trace events#28
Svaag merged 1 commit into
mainfrom
feature/agent-core-trace-v05

Conversation

@Svaag

@Svaag Svaag commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bump agent-core to v0.5.0 for observatory trace correlation fields
  • verify Engineering Loop trace emission includes graph-node traceback events and change/PR/workflow correlation

Validation

  • uv run --group dev mypy src
  • uv run --group dev pytest -q

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be88e0c376

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/test_agent_core_trace.py Outdated
@Svaag Svaag force-pushed the feature/agent-core-trace-v05 branch from be88e0c to 35cf9e7 Compare June 29, 2026 20:35

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35cf9e71b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/hyrule_engineering_loop/agent_core_trace.py
@Svaag Svaag force-pushed the feature/agent-core-trace-v05 branch from 35cf9e7 to 3d71445 Compare June 29, 2026 20:47
@Svaag

Svaag commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Addressed the remaining Codex review in 3d71445: publish paths now call emit_published_trace(...) after pr_results is available (CLI PR command, operator harness, and daemon publish flow), and a regression test covers re-emitting from the real pr_results[].github_pr / pr_results[].commit shape. CI is green.

@Svaag Svaag merged commit b8333f0 into main Jun 29, 2026
4 checks passed
@Svaag Svaag deleted the feature/agent-core-trace-v05 branch June 29, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant